firmware/installPybricksDialog/hooks: Include EV3 zip.#2359
Merged
laurensvalk merged 2 commits intomasterfrom Jan 23, 2026
Merged
firmware/installPybricksDialog/hooks: Include EV3 zip.#2359laurensvalk merged 2 commits intomasterfrom
laurensvalk merged 2 commits intomasterfrom
Conversation
This includes EV3.
Otherwise EV3 installation cannot proceed even when it is included in the firmware NPM package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise EV3 installation cannot proceed even when it is included in the firmware NPM package.
Nitpick: I tried to follow the pattern of the hub name to match the zip/build, which excludes the word brick/hub in this case. But feel free to change if needed.